Minor code revisions for determining installed Framework versions #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
approved these changes
Jan 14, 2019
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
These changes are a great improvement @rpetrusha You can 
when ready.
One suggestion for this or a future PR: I noticed, unrelated to this PR, this code often has if (str != "") as a condition. Would it be better to use string.IsNullOrWhiteSpace or string.IsNullOrEmpty as the test?
Author
|
Yes, it would be better, @BillWagner. I've made the changes in this PR. Thanks for going over the code so carefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor code revisions for determining installed Framework versions
Contributes to dotnet/docs#3991